Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix boolean values getters for RegisterForReflection annotations #38701

Merged
merged 1 commit into from
Feb 12, 2024
Merged

Fix boolean values getters for RegisterForReflection annotations #38701

merged 1 commit into from
Feb 12, 2024

Conversation

zakkak
Copy link
Contributor

@zakkak zakkak commented Feb 9, 2024

Adapt code so that it respects the default value set in the annotation
definition.

@quarkus-bot quarkus-bot bot added the area/core label Feb 9, 2024
@zakkak zakkak mentioned this pull request Feb 9, 2024
Merged
@zakkak zakkak requested a review from gastaldi February 9, 2024 12:01
@gastaldi gastaldi added the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 9, 2024
@zakkak
Fix boolean values getters for RegisterForReflection annotations
04f9286 
Adapt code so that it respects the default value set in the annotation
definition.
@zakkak zakkak force-pushed the 2024-02-09-fix-get-boolean-value branch from dc88973 to 04f9286 Compare February 9, 2024 12:54
@quarkus-bot
Copy link

quarkus-bot bot commented Feb 9, 2024

Status for workflow Quarkus CI

This is the status report for running Quarkus CI on commit 04f9286.

✅ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

Flaky tests - Develocity

⚙️ Maven Tests - JDK 17

📦 integration-tests/maven

✖ io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed - History

  • io.quarkus.maven.it.DevMojoIT expected "ef346e0d-c1e7-4f7d-be09-43d7870b9b5d" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: io.quarkus.maven.it.DevMojoIT expected "ef346e0d-c1e7-4f7d-be09-43d7870b9b5d" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:691)
	at io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed(DevMojoIT.java:967)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

✖ io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed - History

  • io.quarkus.maven.it.DevMojoIT expected "ef346e0d-c1e7-4f7d-be09-43d7870b9b5d" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes. - org.awaitility.core.ConditionTimeoutException
org.awaitility.core.ConditionTimeoutException: io.quarkus.maven.it.DevMojoIT expected "ef346e0d-c1e7-4f7d-be09-43d7870b9b5d" but was "Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua." within 2 minutes.
	at org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:167)
	at org.awaitility.core.AbstractHamcrestCondition.await(AbstractHamcrestCondition.java:86)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:985)
	at org.awaitility.core.ConditionFactory.until(ConditionFactory.java:691)
	at io.quarkus.maven.it.DevMojoIT.testThatNewResourcesAreServed(DevMojoIT.java:967)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

@zakkak zakkak merged commit 0290e66 into quarkusio:main Feb 12, 2024
49 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.9 - main milestone Feb 12, 2024
@zakkak zakkak deleted the 2024-02-09-fix-get-boolean-value branch February 12, 2024 10:23
@quarkus-bot quarkus-bot bot removed the triage/waiting-for-ci Ready to merge when CI successfully finishes label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gastaldi gastaldi gastaldi approved these changes

Assignees
No one assigned
Labels
area/core triage/flaky-test
Projects
None yet
Milestone
3.9.0.CR1
Development

Successfully merging this pull request may close these issues.
2 participants
@zakkak @gastaldi